Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds 'minikube service --all' feature to allow forwarding all services in a namespace #13367

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Adds 'minikube service --all' feature to allow forwarding all services in a namespace #13367

merged 1 commit into from
Feb 9, 2022

Conversation

ckannon
Copy link
Contributor

@ckannon ckannon commented Jan 17, 2022

Adds 'minikube service --all' feature for service to allow forwarding all services in a namespace, also supports multiple service-name arguments to forward any specifically named services.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 17, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @ckannon!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ckannon. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

medyagh
medyagh reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this PR do u mind pasting the output of minikube for an example usage of this feature ?

@ckannon
Copy link
Contributor Author

ckannon commented Jan 18, 2022 •
edited
Loading

Usage and output:
ckannon$ minikube service -n test --all

|-----------|--------------|-------------|-----|
| NAMESPACE |     NAME     | TARGET PORT | URL |
|-----------|--------------|-------------|-----|
| test      | my-service-1 |          80 |     |
| test      | my-service-2 |          80 |     |
| test      | my-service-3 |          80 |     |
|-----------|--------------|-------------|-----|
🏃  Starting tunnel for service my-service-1.
🏃  Starting tunnel for service my-service-2.
🏃  Starting tunnel for service my-service-3.
|-----------|--------------|-------------|------------------------|
| NAMESPACE |     NAME     | TARGET PORT |          URL           |
|-----------|--------------|-------------|------------------------|
| test      | my-service-1 |             | http://127.0.0.1:60337 |
| test      | my-service-2 |             | http://127.0.0.1:60349 |
| test      | my-service-3 |             | http://127.0.0.1:60359 |
|-----------|--------------|-------------|------------------------|
❗  Because you are using a Docker driver on darwin, the terminal needs to be open to run it.

@ckannon
Copy link
Contributor Author

ckannon commented Jan 18, 2022

thank you for this PR do u mind pasting the output of minikube for an example usage of this feature ?

Added, thanks!

@ckannon ckannon closed this Jan 18, 2022
@ckannon ckannon reopened this Jan 18, 2022
@ckannon
Copy link
Contributor Author

ckannon commented Jan 18, 2022

@medyagh Also, can this get an ok-to-test please?

@ckannon
Copy link
Contributor Author

ckannon commented Jan 19, 2022 •
edited
Loading

Oh, it also supports multiple service name args now, instead of just a single one. Usage:

ckannon$ minikube service -n test my-service-1 my-service-2
|-----------|--------------|-------------|-----|
| NAMESPACE |     NAME     | TARGET PORT | URL |
|-----------|--------------|-------------|-----|
| test      | my-service-1 |          80 |     |
| test      | my-service-2 |          80 |     |
|-----------|--------------|-------------|-----|
🏃  Starting tunnel for service my-service-1.
🏃  Starting tunnel for service my-service-2.
|-----------|--------------|-------------|------------------------|
| NAMESPACE |     NAME     | TARGET PORT |          URL           |
|-----------|--------------|-------------|------------------------|
| test      | my-service-1 |             | http://127.0.0.1:63000 |
| test      | my-service-2 |             | http://127.0.0.1:63010 |
|-----------|--------------|-------------|------------------------|
❗  Because you are using a Docker driver on darwin, the terminal needs to be open to run it.

@ckannon ckannon requested a review from medyagh January 19, 2022 17:35
@medyagh
Copy link
Member

medyagh commented Jan 25, 2022

sure ! thank you @ckannon

@medyagh
Copy link
Member

medyagh commented Jan 25, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 25, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 64.0s    | 64.2s               |
| enable ingress | 29.4s    | 29.8s               |
+----------------+----------+---------------------+

Times for minikube start: 63.9s 65.2s 63.4s 63.7s 63.8s
Times for minikube (PR 13367) start: 64.8s 64.3s 63.7s 63.6s 64.6s

Times for minikube (PR 13367) ingress: 30.5s 29.5s 29.5s 29.1s 30.6s
Times for minikube ingress: 29.0s 30.6s 31.1s 26.1s 30.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 39.8s    | 40.0s               |
| enable ingress | 23.5s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube start: 39.6s 39.4s 40.1s 38.8s 41.1s
Times for minikube (PR 13367) start: 40.3s 40.5s 39.7s 39.5s 40.1s

Times for minikube ingress: 23.0s 26.9s 22.9s 22.9s 21.9s
Times for minikube (PR 13367) ingress: 21.9s 23.0s 21.9s 22.4s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 46.9s    | 45.6s               |
| enable ingress | 31.3s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 13367) start: 46.3s 43.9s 47.0s 44.2s 46.6s
Times for minikube start: 46.4s 47.0s 46.8s 47.2s 47.3s

Times for minikube ingress: 30.9s 34.0s 31.0s 30.9s 29.9s
Times for minikube (PR 13367) ingress: 30.9s 38.4s 30.9s 34.4s 34.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestAddons/Setup (gopogh) n/a
Docker_Linux_containerd TestDownloadOnlyKic (gopogh) n/a
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) n/a
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) n/a
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) n/a
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) n/a
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) n/a
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) n/a
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) n/a
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) n/a
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) n/a
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) n/a
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) n/a
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) n/a
Docker_Linux_containerd TestJSONOutput/start/Audit (gopogh) n/a
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) n/a
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) n/a
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) n/a
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) n/a
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) n/a
Docker_Linux_containerd TestMultiNode/serial/PingHostFrom2Pods (gopogh) n/a
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) n/a
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) n/a
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) n/a
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) n/a
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) n/a
Docker_Linux_containerd TestPause/serial/Start (gopogh) n/a
Docker_Linux_containerd TestPreload (gopogh) n/a
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) n/a
Docker_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) n/a
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 46.4s    | 44.9s               |
| enable ingress | 34.2s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 46.2s 44.8s 50.6s 44.2s 46.2s
Times for minikube (PR 13367) start: 45.0s 44.9s 45.5s 44.4s 44.5s

Times for minikube ingress: 37.1s 32.1s 30.6s 40.1s 31.1s
Times for minikube (PR 13367) ingress: 32.1s 32.1s 30.6s 31.1s 31.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 27.1s    | 26.3s               |
| enable ingress | 23.0s    | 24.1s               |
+----------------+----------+---------------------+

Times for minikube start: 27.7s 27.3s 27.7s 26.1s 26.9s
Times for minikube (PR 13367) start: 25.8s 26.0s 26.4s 26.9s 26.4s

Times for minikube ingress: 24.9s 21.9s 21.9s 23.0s 23.4s
Times for minikube (PR 13367) ingress: 25.4s 23.5s 22.9s 26.4s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 40.6s    | 43.4s               |
| enable ingress | 22.6s    | 22.5s               |
+----------------+----------+---------------------+

Times for minikube start: 31.0s 42.5s 41.9s 45.8s 41.8s
Times for minikube (PR 13367) start: 42.8s 42.2s 45.3s 45.2s 41.4s

Times for minikube (PR 13367) ingress: 23.5s 23.9s 19.9s 20.9s 24.4s
Times for minikube ingress: 23.4s 24.4s 23.4s 18.9s 22.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Cloud_Shell TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Docker_Linux_containerd TestNoKubernetes/serial/StartNoArgs (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 0.00 (chart)
Docker_Linux_containerd TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Docker_Linux TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
KVM_Linux TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Docker_macOS TestDownloadOnly/v1.23.2/preload-exists (gopogh) 1.96 (chart)
Docker_macOS TestCertExpiration (gopogh) 3.28 (chart)
Docker_macOS TestCertOptions (gopogh) 3.28 (chart)
Docker_macOS TestDockerFlags (gopogh) 3.28 (chart)
Docker_macOS TestForceSystemdEnv (gopogh) 3.28 (chart)
Docker_macOS TestForceSystemdFlag (gopogh) 3.28 (chart)
Docker_Linux_containerd TestStartStop/group/newest-cni/serial/Pause (gopogh) 4.00 (chart)
Docker_Windows TestJSONOutput/start/Audit (gopogh) 4.76 (chart)
Docker_Windows TestJSONOutput/start/Command (gopogh) 4.76 (chart)
KVM_Linux TestForceSystemdEnv (gopogh) 6.45 (chart)
KVM_Linux TestRunningBinaryUpgrade (gopogh) 6.45 (chart)
Hyper-V_Windows TestPause/serial/Pause (gopogh) 7.14 (chart)
KVM_Linux TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 8.06 (chart)
KVM_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 8.06 (chart)
KVM_Linux_containerd TestStartStop/group/no-preload/serial/AddonExistsAfterStop (gopogh) 8.33 (chart)
KVM_Linux_containerd TestStartStop/group/no-preload/serial/Pause (gopogh) 8.33 (chart)
KVM_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 8.33 (chart)
KVM_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 8.33 (chart)
KVM_Linux_containerd TestStartStop/group/no-preload/serial/VerifyKubernetesImages (gopogh) 8.33 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 10.53 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 1, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 1, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime
error collecting results for kvm2 driver: timing run 0 with minikube: timing cmd: [out/minikube start --driver=kvm2 --container-runtime=docker]: waiting for minikube: exit status 85
docker driver with docker runtime
error downloading artifacts: downloading artifacts: exit status 81docker driver with containerd runtime
error downloading artifacts: downloading artifacts: exit status 81

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Cloud_Shell TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Docker_Linux TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
KVM_Linux TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Pause (gopogh) 20.90 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 20.90 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 20.90 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 20.90 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 22.06 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 23.88 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/DNS (gopogh) 33.33 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/DNS (gopogh) 35.71 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 47.06 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 54.05 (chart)
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 61.64 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 62.50 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 70.00 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 2, 2022
@ckannon ckannon force-pushed the master branch 2 times, most recently from f38f280 to 32b0c09 Compare February 2, 2022 16:39
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 44.8s    | 44.5s               |
| enable ingress | 29.1s    | 28.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 13367) start: 44.1s 43.8s 45.6s 45.1s 44.0s
Times for minikube start: 45.6s 46.1s 44.0s 44.0s 44.5s

Times for minikube ingress: 26.6s 29.1s 30.6s 29.6s 29.6s
Times for minikube (PR 13367) ingress: 29.0s 30.1s 28.6s 29.6s 27.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 26.7s    | 26.1s               |
| enable ingress | 23.3s    | 23.9s               |
+----------------+----------+---------------------+

Times for minikube start: 30.6s 26.1s 25.6s 25.8s 25.5s
Times for minikube (PR 13367) start: 26.3s 26.4s 25.2s 26.6s 26.2s

Times for minikube ingress: 21.9s 25.4s 23.0s 22.9s 23.0s
Times for minikube (PR 13367) ingress: 25.9s 23.4s 22.4s 22.4s 25.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 40.2s    | 42.4s               |
| enable ingress | 26.6s    | 26.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 33.5s 23.4s 22.9s 18.9s 34.5s
Times for minikube (PR 13367) ingress: 22.9s 22.9s 29.9s 23.4s 33.4s

Times for minikube (PR 13367) start: 41.9s 41.8s 44.8s 41.2s 42.2s
Times for minikube start: 31.1s 41.9s 41.9s 45.9s 40.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 0.00 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 0.00 (chart)
Docker_Linux TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
KVM_Linux TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
Docker_Linux TestKubernetesUpgrade (gopogh) 6.67 (chart)
Docker_Linux TestPause/serial/Pause (gopogh) 6.74 (chart)
Docker_Windows TestNetworkPlugins/group/auto/Start (gopogh) 7.58 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 10.94 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 10.94 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 15.15 (chart)
Docker_macOS TestAddons/parallel/MetricsServer (gopogh) 18.68 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 20.78 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 34.85 (chart)
Docker_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 42.19 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 42.22 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 45.31 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 46.97 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 51.52 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 59.09 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 59.09 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 60.78 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 63.33 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 72.22 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 72.73 (chart)
Docker_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 75.00 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 77.78 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Feb 3, 2022

@ckannon plz take a look at the lint :) some go format styles
https://github.com/kubernetes/minikube/runs/5041593907?check_suite_focus=true

and the service functional test

https://storage.googleapis.com/minikube-builds/logs/13367/22506/Docker_Linux.html#fail_TestFunctional%2fparallel%2fServiceCmd

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 53.6s    | 52.5s               |
| enable ingress | 28.5s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube start: 54.9s 51.4s 54.2s 52.3s 55.4s
Times for minikube (PR 13367) start: 51.7s 52.2s 53.3s 52.5s 52.6s

Times for minikube ingress: 26.6s 29.1s 29.0s 29.0s 28.6s
Times for minikube (PR 13367) ingress: 29.6s 26.6s 28.6s 30.0s 25.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 27.2s    | 26.3s               |
| enable ingress | 22.2s    | 22.5s               |
+----------------+----------+---------------------+

Times for minikube start: 30.4s 26.7s 26.3s 26.4s 26.0s
Times for minikube (PR 13367) start: 27.1s 26.2s 26.5s 25.9s 25.9s

Times for minikube ingress: 22.0s 21.9s 21.9s 22.0s 23.4s
Times for minikube (PR 13367) ingress: 23.9s 22.9s 21.9s 21.0s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 39.6s    | 42.4s               |
| enable ingress | 25.0s    | 32.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 23.4s 22.9s 22.9s 22.9s 33.0s
Times for minikube (PR 13367) ingress: 24.4s 33.5s 54.4s 28.9s 23.4s

Times for minikube start: 30.5s 41.6s 42.1s 41.9s 42.1s
Times for minikube (PR 13367) start: 41.0s 41.1s 41.9s 45.6s 42.3s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 52.7s    | 52.5s               |
| enable ingress | 27.3s    | 29.1s               |
+----------------+----------+---------------------+

Times for minikube start: 51.8s 52.4s 51.0s 52.3s 56.0s
Times for minikube (PR 13367) start: 52.0s 51.7s 52.2s 52.5s 54.0s

Times for minikube ingress: 27.0s 29.6s 25.5s 27.0s 27.6s
Times for minikube (PR 13367) ingress: 29.1s 29.1s 30.0s 28.5s 29.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 29.2s    | 26.3s               |
| enable ingress | 35.1s    | 23.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 13367) start: 26.7s 26.5s 25.9s 27.0s 25.4s
Times for minikube start: 42.6s 25.9s 25.5s 26.3s 25.5s

Times for minikube ingress: 82.9s 26.0s 21.9s 22.4s 22.4s
Times for minikube (PR 13367) ingress: 21.9s 22.9s 25.9s 21.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 44.1s    | 44.2s               |
| enable ingress | 20.2s    | 22.3s               |
+----------------+----------+---------------------+

Times for minikube start: 43.3s 44.8s 44.8s 45.3s 42.1s
Times for minikube (PR 13367) start: 41.1s 40.9s 46.6s 46.0s 46.3s

Times for minikube ingress: 22.4s 18.9s 18.9s 18.9s 21.9s
Times for minikube (PR 13367) ingress: 23.4s 22.5s 18.9s 18.0s 28.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestAddons/serial/GCPAuth (gopogh) 0.00 (chart)
KVM_Linux TestNetworkPlugins/group/false/Start (gopogh) 6.29 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 6.77 (chart)
Docker_Linux TestPause/serial/Pause (gopogh) 9.85 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 11.11 (chart)
KVM_Linux TestNetworkPlugins/group/kubenet/Start (gopogh) 12.59 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 26.37 (chart)
Docker_macOS TestAddons/parallel/MetricsServer (gopogh) 40.15 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 51.88 (chart)
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 63.81 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 69.17 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 98.50 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 100.00 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestNetworkPlugins/group/calico/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestSkaffold (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/NetCatPod (gopogh) 0.00 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/DNS (gopogh) 2.27 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 6.77 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 8.11 (chart)
KVM_Linux_containerd TestCertExpiration (gopogh) 8.51 (chart)
KVM_Linux_containerd TestCertOptions (gopogh) 8.51 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 12.06 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/cilium/Start (gopogh) 13.48 (chart)
Docker_Windows TestStartStop/group/no-preload/serial/Pause (gopogh) 14.13 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/flannel/Start (gopogh) 14.89 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 19.15 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 22.58 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 25.00 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 25.00 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 25.00 (chart)
Docker_Linux_containerd TestJSONOutput/start/Audit (gopogh) 25.00 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 25.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 25.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 25.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 25.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 25.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 25.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 25.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) 25.00 (chart)
Docker_Linux_containerd TestPreload (gopogh) 25.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 25.86 (chart)
Docker_Linux_containerd TestOffline (gopogh) 27.59 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

medyagh
medyagh approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @ckannon

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckannon, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2022
@ckannon
Copy link
Contributor Author

ckannon commented Feb 9, 2022

Thank you for this PR @ckannon

@medyagh Thanks! Repushed, fixed linting.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 52.2s    | 52.4s               |
| enable ingress | 27.6s    | 29.1s               |
+----------------+----------+---------------------+

Times for minikube start: 53.1s 51.3s 51.9s 52.8s 51.8s
Times for minikube (PR 13367) start: 52.0s 52.5s 52.9s 52.3s 52.5s

Times for minikube (PR 13367) ingress: 29.6s 28.6s 29.1s 29.0s 29.1s
Times for minikube ingress: 29.6s 26.1s 25.6s 27.1s 29.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 29.5s    | 26.2s               |
| enable ingress | 22.7s    | 35.2s               |
+----------------+----------+---------------------+

Times for minikube start: 42.0s 26.1s 27.2s 26.2s 26.2s
Times for minikube (PR 13367) start: 25.4s 26.8s 26.1s 26.3s 26.3s

Times for minikube ingress: 22.9s 23.5s 23.0s 22.0s 21.9s
Times for minikube (PR 13367) ingress: 21.9s 25.4s 21.9s 23.4s 83.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13367) |
+----------------+----------+---------------------+
| minikube start | 43.6s    | 44.7s               |
| enable ingress | 22.8s    | 20.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 18.9s 18.9s 23.4s 29.9s 22.9s
Times for minikube (PR 13367) ingress: 19.4s 23.4s 19.0s 19.9s 19.9s

Times for minikube start: 45.5s 45.2s 41.1s 44.6s 41.7s
Times for minikube (PR 13367) start: 44.9s 41.7s 46.3s 45.6s 45.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDownloadOnly/v1.23.3/preload-exists (gopogh) 0.00 (chart)
KVM_Linux TestPause/serial/VerifyDeletedResources (gopogh) 0.00 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 1.61 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 2.13 (chart)
Hyper-V_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 2.97 (chart)
Hyper-V_Windows TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 2.97 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 3.55 (chart)
Hyper-V_Windows TestNetworkPlugins/group/calico/Start (gopogh) 5.94 (chart)
Hyper-V_Windows TestNetworkPlugins/group/false/Start (gopogh) 7.92 (chart)
Hyper-V_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 9.90 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 17.73 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 19.15 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 20.79 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 24.11 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 24.11 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 54.61 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/DNS (gopogh) 56.10 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 60.40 (chart)
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 63.39 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 64.71 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 69.50 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 75.53 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 79.35 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 81.52 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 83.69 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 86.52 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 87.23 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 98.58 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 100.00 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit d6120f1 into kubernetes:master Feb 9, 2022
@medyagh medyagh mentioned this pull request Mar 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@klaases klaases Awaiting requested review from klaases

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ckannon @k8s-ci-robot @minikube-bot @medyagh @minikube-pr-bot